linux-kernel - Re: [PATCH] platform/chrome: Don't treat RTC events as wakeup sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160521341449.487210.11292541473208275402.b4-ty@collabora.com>
Date:   Fri, 13 Nov 2020 09:56:25 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Benson Leung <bleung@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>
Cc:     kernel@...labora.com, Alessandro Zummo <a.zummo@...ertech.it>,
        Guenter Roeck <groeck@...omium.org>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH] platform/chrome: Don't treat RTC events as wakeup sources

On Fri, 30 Oct 2020 16:25:23 -0700, Stephen Boyd wrote:
> The EC sends an RTC host event when the RTC fires, but we don't need to
> treat that as a wakeup event here. The RTC class already properly
> handles activating and deactivating a wakeup source in rtc_update_irq()
> by calling pm_stay_awake() at the start of processing and pm_relax()
> once all expired RTC timers have been processed. This reduces one wakeup
> increment but not much else. I noticed this while debugging RTC wakeups
> and how they always incremented the wakeup count by two instead of one
> because this is duplicated.

Applied, thanks!

[1/1] platform/chrome: Don't treat RTC events as wakeup sources
      commit: 853c1a789f5fe8e783586a5c2dcc2ad1b57ac20f

Best regards,
-- 
Enric Balletbo i Serra <enric.balletbo@...labora.com>