linux-kernel - Re: [PATCH] phy: tegra: Don't warn on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfcfb222-2b4d-31e9-a868-b9e7a7e0cc6e@nvidia.com>
Date:   Fri, 13 Nov 2020 17:21:39 +0800
From:   JC Kuo <jckuo@...dia.com>
To:     Jon Hunter <jonathanh@...dia.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] phy: tegra: Don't warn on probe deferral

On 11/11/20 6:37 PM, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
> 
> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
> ---
>  drivers/phy/tegra/xusb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ad88d74c1884..2eafb813825b 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1200,7 +1200,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
>  	err = devm_regulator_bulk_get(&pdev->dev, padctl->soc->num_supplies,
>  				      padctl->supplies);
>  	if (err < 0) {
> -		dev_err(&pdev->dev, "failed to get regulators: %d\n", err);
> +		dev_err_probe(&pdev->dev, err, "failed to get regulators\n");
>  		goto remove;
>  	}
>  
> 
Acked-by: JC Kuo <jckuo@...dia.com>