linux-kernel - Re: [PATCH RFC v5 01/13] perf jevents: Add support for an extra directory level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ca35e0f-e5e6-8616-0435-0f8e553df1f9@huawei.com>
Date:   Fri, 13 Nov 2020 09:24:39 +0000
From:   John Garry <john.garry@...wei.com>
To:     kajoljain <kjain@...ux.ibm.com>, <acme@...nel.org>,
        <will@...nel.org>, <mark.rutland@....com>, <jolsa@...hat.com>,
        <irogers@...gle.com>, <leo.yan@...aro.org>, <peterz@...radead.org>,
        <mingo@...hat.com>, <alexander.shishkin@...ux.intel.com>,
        <namhyung@...nel.org>, <mathieu.poirier@...aro.org>
CC:     <linuxarm@...wei.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <qiangqing.zhang@....com>,
        <zhangshaokun@...ilicon.com>, <linux-imx@....com>
Subject: Re: [PATCH RFC v5 01/13] perf jevents: Add support for an extra
 directory level

On 13/11/2020 08:48, kajoljain wrote:
> 
> On 11/6/20 6:05 PM, John Garry wrote:
>> Currently only upto a level 2 directory is supported, in form
>> vendor/platform.
> Hi John,
>      Just want to check in case of sub directories,
> Will it be good add on/feasible to be able to include events of particular sub-directory for a
> platform? Otherwise with this patch in the end all event will be part of
> same pmu_event structure. So what is the purpose of sub directories? Let me know if I am missing something.

Hi Kajol Jain,

So currently we support both of the following structure:
arch/platform
arch/vendor/platform/

arch/vendor/platform/ is for an arch like arm, where the arch provider 
may not be the vendor.

I want to go one step further, to support also:
arch/vendor/platform/cpu
arch/vendor/platform/sys

Here we have separate folders for cpu and sys events. CPU events in 
"cpu" folder are added to pmu_events_map[], as before. And events in 
"sys" folder are added from patch 2/13 to new table pmu_sys_events_table[].

I hope it's clearer now.

Thanks,
John

> 
> Thanks,
> Kajol Jain
>> Add support for a further level, to support vendor/platform
>> sub-directories in future.