linux-kernel - Re: [PATCH v2] mfd: kempld-core: Check for DMI definition before ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201113101438.GF3718728@dell>
Date:   Fri, 13 Nov 2020 10:14:38 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Michael Brunner <Michael.Brunner@...tron.com>,
        "sameo@...ux.intel.com" <sameo@...ux.intel.com>,
        "mibru@....de" <mibru@....de>,
        "vkrasnov@....rtsoft.ru" <vkrasnov@....rtsoft.ru>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mvanyulin@....rtsoft.ru" <mvanyulin@....rtsoft.ru>
Subject: Re: [PATCH v2] mfd: kempld-core: Check for DMI definition before ACPI

On Tue, 10 Nov 2020, Guenter Roeck wrote:

> On Tue, Nov 10, 2020 at 03:23:21PM +0000, Michael Brunner wrote:
> > Change the detection order to priorize DMI table entries over available
> > ACPI entries.
> > 
> > This makes it more easy for product developers to patch product specific
> > handling into the driver.
> > Furthermore it allows to simplify the implementation a bit and
> > especially to remove the need to force synchronous probing.
> > 
> > Based on the following commit introduced with v5.10-rc1:
> > commit e8299c7313af ("mfd: Add ACPI support to Kontron PLD driver")
> > 
> > v2: Fixed coding style as suggested by Guenther Roeck
> > 
> 
> Nit: change logs should be after '---'.

Right.  Please submit a v3 fixing this.

> Other than that,
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog