linux-kernel - Re: [PATCH v2 2/3] net: openvswitch: use core API to update/provide stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4409cfe-4d58-27da-0c0d-3c59ce508aea@gmail.com>
Date:   Fri, 13 Nov 2020 11:46:18 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Lev Stipakov <lstipakov@...il.com>,
        Pravin B Shelar <pshelar@....org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        dev@...nvswitch.org, linux-kernel@...r.kernel.org
Cc:     Lev Stipakov <lev@...nvpn.net>
Subject: Re: [PATCH v2 2/3] net: openvswitch: use core API to update/provide
 stats

Am 13.11.2020 um 10:02 schrieb Lev Stipakov:
> Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added
> function "dev_sw_netstats_tx_add()" to update net device per-cpu TX
> stats.
> 
> Use this function instead of own code.
> 
> While on it, remove internal_get_stats() and replace it
> with dev_get_tstats64().
> 
> Signed-off-by: Lev Stipakov <lev@...nvpn.net>
> ---
> 
>  v2:
>   - do not delete len variable and add comment why
>   - replace internal_get_stats() vs dev_get_tstats64()
> 
Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>