linux-kernel - RE: [PATCH] altera-stapl: remove the unreached switch case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d7336acc20d4a7687bbf2a8c6de3454@AcuMS.aculab.com>
Date:   Fri, 13 Nov 2020 11:20:56 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'xiakaixu1987@...il.com'" <xiakaixu1987@...il.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: RE: [PATCH] altera-stapl: remove the unreached switch case

From: xiakaixu1987@...il.com 
> Sent: 13 November 2020 09:21
> From: Kaixu Xia <kaixuxia@...cent.com>
> 
> The value of the variable status must be one of the 0, -EIO and -EILSEQ, so
> the switch cases -ENODATA and default are unreached. Remove them.
> 
> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
> ---
>  drivers/misc/altera-stapl/altera.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/misc/altera-stapl/altera.c b/drivers/misc/altera-stapl/altera.c
> index 5bdf574..8ad1e9e 100644
> --- a/drivers/misc/altera-stapl/altera.c
> +++ b/drivers/misc/altera-stapl/altera.c
> @@ -2265,19 +2265,10 @@ static int altera_check_crc(u8 *p, s32 program_size)
>  				"actual %04x\n", __func__, local_expected,
>  				local_actual);
>  			break;
> -		case -ENODATA:
> -			printk(KERN_ERR "%s: expected CRC not found, "
> -				"actual CRC = %04x\n", __func__,
> -				local_actual);
> -			break;
>  		case -EIO:
>  			printk(KERN_ERR "%s: error: format isn't "
>  				"recognized.\n", __func__);
>  			break;
> -		default:
> -			printk(KERN_ERR "%s: CRC function returned error "
> -				"code %d\n", __func__, status);
> -			break;

You ought to leave a 'default' in there.
Even if it is just the same as -EIO.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)