linux-kernel - Re: R: [PATCH] arm64: fix missing include in asm uaccess.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201112164809.81f1c14f5d1f1d998f279287@linux-foundation.org>
Date:   Thu, 12 Nov 2020 16:48:09 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     <ansuelsmth@...il.com>
Cc:     "'Al Viro'" <viro@...iv.linux.org.uk>,
        "'Will Deacon'" <will@...nel.org>,
        "'Catalin Marinas'" <catalin.marinas@....com>,
        "'Mark Rutland'" <mark.rutland@....com>,
        "'Pavel Tatashin'" <pasha.tatashin@...een.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: R: [PATCH] arm64: fix missing include in asm uaccess.h

On Wed, 11 Nov 2020 02:19:48 +0100 <ansuelsmth@...il.com> wrote:

> > <asm/uaccess.h> ok ? */
> > include/linux/uaccess.h:11:#include <asm/uaccess.h>
> > 
> > The last one is the only such include that should exist; drivers/s390 one
> > is obviously a false positive.  And IMO the right thing to do is to
> > replace the remaining arch/* instances with includes of linux/uaccess.h.
> > 
> > All of those are asking for trouble; any change moving e.g. a common
> > variant of some primitive into linux/uaccess.h might end up breaking
> > those.
> 
> Thx for the quick response. I found this error while working on a qcom
> driver that
> use this include. I can confirm that by using linux/uaccess.h the problem is
> solved.

Thanks, all.

I queued up the below for sending to Linus Real Soon Now.  Please note
that I added the cc:stable, because the offending df325e05a6 ("arm64:
Validate tagged addresses in access_ok() called from kernel threads")
had a cc:stable.


From: Ansuel Smith <ansuelsmth@...il.com>
Subject: arm64: fix missing include in asm/uaccess.h

Fix a compilation error as PF_KTHREAD is defined in linux/sched.h and this
is missing.

[viro@...iv.linux.org.uk: use linux/uaccess.h]
  Link: https://lkml.kernel.org/r/20201111005826.GY3576660@ZenIV.linux.org.uk
Link: https://lkml.kernel.org/r/20201111004440.8783-1-ansuelsmth@gmail.com
Fixes: df325e05a682 ("arm64: Validate tagged addresses in access_ok() called from kernel threads")
Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
Cc: Will Deacon <will@...nel.org>
Cc: Catalin Marinas <catalin.marinas@....com>
Cc: Mark Rutland <mark.rutland@....com>
Cc: Pavel Tatashin <pasha.tatashin@...een.com>
Cc: <stable@...r.kernel.org>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 arch/arm64/include/asm/uaccess.h |    2 ++
 1 file changed, 2 insertions(+)

--- a/arch/arm64/include/asm/uaccess.h~arm64-fix-missing-include-in-asm-uaccessh
+++ a/arch/arm64/include/asm/uaccess.h
@@ -7,6 +7,8 @@
 #ifndef __ASM_UACCESS_H
 #define __ASM_UACCESS_H
 
+#include <linux/uaccess.h>
+
 #include <asm/alternative.h>
 #include <asm/kernel-pgtable.h>
 #include <asm/sysreg.h>
_