linux-kernel - Re: [PATCH v2 2/2] Documentation: scheduler: ask users to set sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jhj5z69xzi7.mognet@arm.com>
Date:   Fri, 13 Nov 2020 11:34:21 +0000
From:   Valentin Schneider <valentin.schneider@....com>
To:     Barry Song <song.bao.hua@...ilicon.com>
Cc:     corbet@....net, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Mel Gorman <mgorman@...e.de>, Adrian Freund <adrian@...und.io>
Subject: Re: [PATCH v2 2/2] Documentation: scheduler: ask users to set sched_debug cmdline


On 12/11/20 22:31, Barry Song wrote:
> From: Valentin Schneider <valentin.schneider@....com>
>
> To print the schedule debug information, users need to set sched_debug
> cmdline or enable it by sysfs entry.
>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Adrian Freund <adrian@...und.io>
> Signed-off-by: Valentin Schneider <valentin.schneider@....com>

FYI, forging SoB, or any 'tag' other than Suggested-by / Reported-by is
frowned up. Now I do appreciate your effort to give me credit, but in this
case you should've used Suggested-by.

Moreso, this really is a trivial change and doesn't deserve a separate
patch, so I would say just squash that into patch 1, and add

Reviewed-by: Valentin Schneider <valentin.schneider@....com>

to it :)

> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
> ---
>  Documentation/scheduler/sched-domains.rst | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-domains.rst b/Documentation/scheduler/sched-domains.rst
> index 55983b7e1098..8582fa5e9170 100644
> --- a/Documentation/scheduler/sched-domains.rst
> +++ b/Documentation/scheduler/sched-domains.rst
> @@ -74,6 +74,8 @@ for a given topology level by creating a sched_domain_topology_level array and
>  calling set_sched_topology() with this array as the parameter.
>  
>  The sched-domains debugging infrastructure can be enabled by enabling
> -CONFIG_SCHED_DEBUG. This enables an error checking parse of the sched domains
> -which should catch most possible errors (described above). It also prints out
> -the domain structure in a visual format.
> +CONFIG_SCHED_DEBUG and adding 'sched_debug' to your cmdline. If you forgot to
> +tweak your cmdline, you can also flip the /sys/kernel/debug/sched_debug
> +knob. This enables an error checking parse of the sched domains which should
> +catch most possible errors (described above). It also prints out the domain
> +structure in a visual format.