linux-kernel - Re: [PATCH 0/3] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X66Uo83dTGS2dMcx@kroah.com>
Date:   Fri, 13 Nov 2020 15:13:55 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        heikki.krogerus@...ux.intel.com, enric.balletbo@...labora.com,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH 0/3] platform/chrome: cros_ec_typec: Add plug and plug
 altmodes

On Wed, Nov 11, 2020 at 05:23:25PM -0800, Prashant Malani wrote:
> This patch series add plug registration support to the cros-ec-typec
> driver. It also adds support for registering alternate modes for the
> registered plug. These features utilize the API provided by the Type C
> connector class framework.
> 
> The first patch adds support to the connector class framework for the
> number_of_alternate_modes attribute (along with the relevant ABI
> documentation).
> 
> The next two patches add plug registration, and then altmode
> registration for the plugs. The latter of these two patches utilizes the
> new function for plug number_of_alternate_modes introduced in the first patch.
> 
> This series is based on top of the following branch and other patch
> series (applied in the order specified):
> - Branch: chrome-platform for-next [1], which is currently set to the
>   "Linux 5.10-rc1" tag.
> - cros-ec-typec: Patch series to register PD identity information + partner altmodes[2]
> - cros-ec-typec: Patch series to register cable[3]
> - cros-ec-typec: Patch series to add partner number_of_altmodes[4]
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git/log/?h=for-next
> [2]: https://lore.kernel.org/lkml/20201029222738.482366-1-pmalani@chromium.org/
> [3]: https://lore.kernel.org/lkml/20201106184104.939284-1-pmalani@chromium.org/
> [4]: https://lore.kernel.org/lkml/20201110061535.2163599-1-pmalani@chromium.org/

Ok, I'm confused.  This is not the first submission of this series, as
you sent out a v2 a few days before this one.

And am I supposed to suck in the chrome-platform branch into the
usb-next tree?

What should I do here, ignore these?  Merge them?

I see the USB change lost the reviewer's ack as well, why?

I'm going to delete all of these patches from my review queue now and
wait for a resend with some clarity as to what I should do with it :)

thanks,

greg k-h