linux-kernel - Re: [PATCH] tracing: remove the unused value assignment in test_create_synth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201113093326.36f769de@gandalf.local.home>
Date:   Fri, 13 Nov 2020 09:33:26 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     xiakaixu1987@...il.com
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] tracing: remove the unused value assignment in
 test_create_synth_event

On Fri, 13 Nov 2020 15:33:30 +0800
xiakaixu1987@...il.com wrote:

> From: Kaixu Xia <kaixuxia@...cent.com>
> 
> The value of variable ret is overwritten on the delete branch in the
> test_create_synth_event(), so here the value assignment is useless.
> Remove it.
> 

No. The correct fix is to remove the useless assignment of ret in the
delete portion. We care more about this error than we do about errors
happening in cleaning up the breakage.

-- Steve


> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
> ---
>  kernel/trace/synth_event_gen_test.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/trace/synth_event_gen_test.c b/kernel/trace/synth_event_gen_test.c
> index edd912cd14aa..c76b4c189560 100644
> --- a/kernel/trace/synth_event_gen_test.c
> +++ b/kernel/trace/synth_event_gen_test.c
> @@ -276,10 +276,8 @@ static int __init test_create_synth_event(void)
>  	 */
>  	create_synth_test = trace_get_event_file(NULL, "synthetic",
>  						 "create_synth_test");
> -	if (IS_ERR(create_synth_test)) {
> -		ret = PTR_ERR(create_synth_test);
> +	if (IS_ERR(create_synth_test))
>  		goto delete;
> -	}
>  
>  	/* Enable the event or you won't see anything */
>  	ret = trace_array_set_clr_event(create_synth_test->tr,