linux-kernel - Re: [PATCH] checkpatch: fix typo and remove duplicate word

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 07:00:50 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com
Subject: Re: [PATCH] checkpatch: fix typo and remove duplicate word

On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
> 
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@...il.com>
> ---

style: this should have subject prefix:

"[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"

And here below the --- line you should add a V2 changelog like:

o Add correction for falsly

Other than that, you might consider sending a V3 just to get
used the proper patch resubmission form but thanks.

>  scripts/checkpatch.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2749f32dffe9..041b82f6669e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2841,7 +2841,7 @@ sub process {
>  
> 
>  
> 
>  				# stable@...r.kernel.org or stable@...nel.org shouldn't
> -				# have an email name. In addition commments should strictly
> +				# have an email name. In addition comments should strictly
>  				# begin with a #
>  				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
>  					if (($comment ne "" && $comment !~ /^#.+/) ||
> @@ -5000,7 +5000,7 @@ sub process {
>  ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
>  ##
>  ## 			# Remove any bracketed sections to ensure we do not
> -## 			# falsly report the parameters of functions.
> +## 			# falsely report the parameters of functions.
>  ## 			my $ln = $line;
>  ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
>  ## 			}
> @@ -7109,7 +7109,7 @@ sub process {
>  		exit(0);
>  	}
>  
> 
> -	# This is not a patch, and we are are in 'no-patch' mode so
> +	# This is not a patch, and we are in 'no-patch' mode so
>  	# just keep quiet.
>  	if (!$chk_patch && !$is_patch) {
>  		exit(0);