linux-kernel - Re: [PATCH] reboot: sync documentation with current code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFnufp1WrFKx1OnWqcv-sfeF=TL9jw=V0Qg+GidQJz9DEc=jzA@mail.gmail.com>
Date:   Fri, 13 Nov 2020 02:50:47 +0100
From:   Matteo Croce <mcroce@...ux.microsoft.com>
To:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Nathan Chancellor <natechancellor@...il.com>,
        Petr Mladek <pmladek@...e.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] reboot: sync documentation with current code

On Fri, Nov 13, 2020 at 2:07 AM Matteo Croce <mcroce@...ux.microsoft.com> wrote:
>
> From: Matteo Croce <mcroce@...rosoft.com>
>
> The valid values accepted by /sys/kernel/reboot/type are a bit different
> that the ones used in the kernel command line.
>
> In /sys we supports 'cf9_force' and 'cf9_safe', while in the kernel command
> line 'pci' and 'q' are used.
>
> Document the right values in the sysfs documentation.
>
> Fixes: eab8da48579d ("reboot: allow to specify reboot mode via sysfs")
> Signed-off-by: Matteo Croce <mcroce@...rosoft.com>
> ---
>  Documentation/ABI/testing/sysfs-kernel-reboot | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-kernel-reboot b/Documentation/ABI/testing/sysfs-kernel-reboot
> index 837330fb2511..fcc5d193c16c 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-reboot
> +++ b/Documentation/ABI/testing/sysfs-kernel-reboot
> @@ -16,7 +16,8 @@ What:         /sys/kernel/reboot/type
>  Date:          November 2020
>  KernelVersion: 5.11
>  Contact:       Matteo Croce <mcroce@...rosoft.com>
> -Description:   Reboot type. Valid values are: bios acpi kbd triple efi pci
> +Description:   Reboot type. Valid values are:
> +               bios acpi kbd triple efi cf9_force cf9_safe
>
>  What:          /sys/kernel/reboot/cpu
>  Date:          November 2020
> --
> 2.28.0
>

So, discard this one, I will rename 'cf9_force' to 'pci' instead.
Simpler, and coherent with the kernel cmdline.

-- 
per aspera ad upstream