linux-kernel - Re: [PATCH net v2] net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112180254.66be25cd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Nov 2020 18:02:54 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xie He <xie.he.0141@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Martin Schiller <ms@....tdt.de>
Subject: Re: [PATCH net v2] net: x25: Increase refcnt of "struct x25_neigh"
 in x25_rx_call_request

On Thu, 12 Nov 2020 02:35:06 -0800 Xie He wrote:
> The x25_disconnect function in x25_subr.c would decrease the refcount of
> "x25->neighbour" (struct x25_neigh) and reset this pointer to NULL.
> 
> However, the x25_rx_call_request function in af_x25.c, which is called
> when we receive a connection request, does not increase the refcount when
> it assigns the pointer.
> 
> Fix this issue by increasing the refcount of "struct x25_neigh" in
> x25_rx_call_request.
> 
> This patch fixes frequent kernel crashes when using AF_X25 sockets.
> 
> Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
> Cc: Martin Schiller <ms@....tdt.de>
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied, thanks!