linux-kernel - Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ee0261c-c6c7-96f2-a15c-587becb28b06@ti.com>
Date:   Sat, 14 Nov 2020 06:15:55 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Nishanth Menon <nm@...com>, Sekhar Nori <nsekhar@...com>,
        <robh+dt@...nel.org>
CC:     Lokesh Vutla <lokeshvutla@...com>, Faiz Abbas <faiz_abbas@...com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <t-kristo@...com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main
 domain

Hi

On 13/11/2020 22:55, Nishanth Menon wrote:
> On 00:39-20201114, Sekhar Nori wrote:
>>
>> I was using the latest schema from master. But I changed to 2020.08.1
>> also, and still don't see the warning.
>>
>> $ dt-doc-validate --version
>> 2020.12.dev1+gab5a73fcef26
>>
>> I dont have a system-wide dtc installed. One in kernel tree is updated.
>>
>> $ scripts/dtc/dtc --version
>> Version: DTC 1.6.0-gcbca977e
>>
>> Looking at your logs, it looks like you have more patches than just this
>> applied. I wonder if thats making a difference. Can you check with just
>> these patches applied to linux-next or share your tree which includes
>> other patches?
>>
>> In your logs, you have such error for other interrupt controller nodes
>> as well. For example:
>>
>>   arch/arm64/boot/dts/ti/k3-j7200-main.dtsi:
>> /bus@...000/bus@...00000/interrupt-controller1: Missing #address-cells
>> in interrupt provider
>>
>> Which I don't see in my logs. My guess is some other patch(es) in your
>> patch stack either uncovers this warning or causes it.
> 
> Oh boy! I sent you and myself on wild goose chase! Really sorry about
> messing up in the report of bug.
> 
> It is not dtbs_check, it is building dtbs with W=2 that generates this
> warning. dtc 1.6.0 is sufficient to reproduce this behavior.
> 
> Using v5.10-rc1 as baseline (happens the same with next-20201113 as
> 		well.
> 
> v5.10-rc1: https://pastebin.ubuntu.com/p/Pn9HDqRjQ4/ (recording:
>      https://asciinema.org/a/55YVpql9Bq8rh8fePTxI2xObO)
> 
> v5.10-rc1 + 1st patch in the series(since we are testing):
> 	https://pastebin.ubuntu.com/p/QWQRMSv565/ (recording:
> https://asciinema.org/a/ZSKZkOY13l4lmZ2xWH34jMlM1)
> 
> Diff: https://pastebin.ubuntu.com/p/239sYYT2QY/
> 

This warning come from scripts/dtc/checks.c
and was introduced by commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version v1.6.0-11-g9d7888cbf19c").

In my opinion it's false warning as there is no requirement to have  #address-cells in interrupt provider node.
by the way, above commit description says: "The interrupt_provider check is noisy, so turn it off for now."

-- 
Best regards,
grygorii