linux-kernel - Re: [PATCH v4 04/16] mm: Add FGP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201114100053.GE19102@lst.de>
Date:   Sat, 14 Nov 2020 11:00:53 +0100
From:   Christoph Hellwig <hch@....de>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, hughd@...gle.com, hch@....de,
        hannes@...xchg.org, yang.shi@...ux.alibaba.com,
        dchinner@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 04/16] mm: Add FGP_ENTRY

On Thu, Nov 12, 2020 at 09:26:29PM +0000, Matthew Wilcox (Oracle) wrote:
> The functionality of find_lock_entry() and find_get_entry() can be
> provided by pagecache_get_pages(),

s/pagecache_get_pages/pagecache_get_page/

> which lets us delete find_lock_entry()
> and make find_get_entry() static.

I think this should mention that find_get_entry is now only used by
pagecache_get_page.  That answers the obvious questions of why we could
not switch all callers of find_get_entry to pagecache_get_page.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>