linux-kernel - Re: [PATCH v4 11/16] mm: Add an 'end' parameter to pagevec_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201114101905.GL19102@lst.de>
Date:   Sat, 14 Nov 2020 11:19:05 +0100
From:   Christoph Hellwig <hch@....de>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, hughd@...gle.com, hch@....de,
        hannes@...xchg.org, yang.shi@...ux.alibaba.com,
        dchinner@...hat.com, linux-kernel@...r.kernel.org,
        Jan Kara <jack@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>
Subject: Re: [PATCH v4 11/16] mm: Add an 'end' parameter to
 pagevec_lookup_entries

On Thu, Nov 12, 2020 at 09:26:36PM +0000, Matthew Wilcox (Oracle) wrote:
> Simplifies the callers and uses the existing functionality
> in find_get_entries().  We can also drop the final argument of
> truncate_exceptional_pvec_entries() and simplify the logic in that
> function.

I'd say the truncate_exceptional_pvec_entries simpliciation is a separate
step and should normally be a separate patch.

But otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@....de>