linux-kernel - Re: [PATCH] ASoC: samsung: remove the unused variable value assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201114154936.GC14208@kozik-lap>
Date:   Sat, 14 Nov 2020 16:49:36 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     xiakaixu1987@...il.com
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] ASoC: samsung: remove the unused variable value
 assignment

On Fri, Nov 13, 2020 at 10:51:19PM +0800, xiakaixu1987@...il.com wrote:
> From: Kaixu Xia <kaixuxia@...cent.com>
> 
> The value of variable ret is overwritten by the following call
> devm_snd_soc_register_card(), so here the value assignment is useless.
> Remove it.
> 
> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>

Where can we find the report?

> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
> ---
>  sound/soc/samsung/smdk_wm8994.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c
> index 64a1a64..1db5b59 100644
> --- a/sound/soc/samsung/smdk_wm8994.c
> +++ b/sound/soc/samsung/smdk_wm8994.c
> @@ -160,11 +160,9 @@ static int smdk_audio_probe(struct platform_device *pdev)
>  		smdk_dai[0].cpus->dai_name = NULL;
>  		smdk_dai[0].cpus->of_node = of_parse_phandle(np,
>  				"samsung,i2s-controller", 0);
> -		if (!smdk_dai[0].cpus->of_node) {
> +		if (!smdk_dai[0].cpus->of_node)
>  			dev_err(&pdev->dev,
>  			   "Property 'samsung,i2s-controller' missing or invalid\n");
> -			ret = -EINVAL;

This should jump to out/return instead.

Please use script get_maintainers.pl to get the list of people and
mailing lists to Cc. No one would apply this patch otherwise...

Best regards,
Krzysztof