linux-kernel - Re: [PATCH] rtc: Fix memleak in sun6i_rtc_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201114221638.GP4556@piout.net>
Date:   Sat, 14 Nov 2020 23:16:38 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Youling Tang <tangyouling@...ngson.cn>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>, linux-rtc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: Fix memleak in sun6i_rtc_clk_init

Hi,

Thank you for the patch.

On 14/11/2020 12:18:21+0800, Youling Tang wrote:
> When rtc->base or rtc->int_osc or rtc->losc or rtc->ext_losc is NULL,
> we should free clk_data and rtc before the function returns to prevent
> memleak.
> 

I think this is fixed by 28d211919e422f58c1e6c900e5810eee4f1ce4c8 in my
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=28d211919e422f58c1e6c900e5810eee4f1ce4c8

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com