linux-kernel - Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X7BhFOA9uPAUluv0@shinobu>
Date:   Sat, 14 Nov 2020 17:58:28 -0500
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Kamel Bouhara <kamel.bouhara@...tlin.com>
Cc:     jic23@...nel.org, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check

On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote:
> On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote:
> > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote:
> > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values
> > > for CMR. This patch fixes the action_get() callback to properly check
> > > for these values rather than mask them.
> > > 
> > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
> > > Cc: Kamel Bouhara <kamel.bouhara@...tlin.com>
> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > 
> > > ---
> > >  drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------
> > >  1 file changed, 10 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
> > > index 039c54a78aa5..142b389fc9db 100644
> > > --- a/drivers/counter/microchip-tcb-capture.c
> > > +++ b/drivers/counter/microchip-tcb-capture.c
> > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter,
> > >  
> > >  	regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr);
> > >  
> > > -	*action = MCHP_TC_SYNAPSE_ACTION_NONE;
> > > -
> > > -	if (cmr & ATMEL_TC_ETRGEDG_NONE)
> > > +	switch (cmr & ATMEL_TC_ETRGEDG_BOTH) {
> 
> BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask.

You're right, let me resubmit this patch with that change since it'll be
much clearer.

By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is
Kamel the maintainer of this driver? I'd like to get a proper entry
added so we have a point of contact in case of future bugs and changes.

Thanks,

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)