linux-kernel - Re: [PATCH 00/13 v4] perf tools: fix perf stat with large socket IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201115211802.GE1081385@krava>
Date:   Sun, 15 Nov 2020 22:18:02 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     James Clark <james.clark@....com>,
        Stephane Eranian <eranian@...gle.com>,
        Andi Kleen <andi@...stfloor.org>
Cc:     linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        John Garry <john.garry@...wei.com>
Subject: Re: [PATCH 00/13 v4] perf tools: fix perf stat with large socket IDs

On Fri, Nov 13, 2020 at 07:26:41PM +0200, James Clark wrote:
> v3 had a mistake in a couple of my signed off lines so I have fixed them
> in v4.
> 
> v3 breaks up the previous v2 patchset into smaller atomic commits.
> The end result is the same as the previous patchset apart from
> some minor refactoring, asserting on an empty header and
> calling cpu__setup_cpunode_map() in the topology self test.
> 
> Testing done:
> 
> Tested --per-core, --per-thread, --per-die, --per-node 'perf
> stat' outputs on Arm ThunderX2 and Intel KNL.
> 
> Also tested 'perf stat record' and 'perf stat report --input'
> with recordings from a version of perf before this patchset
> to confirm that the output was the same.
> 
> Signed-off-by: James Clark <james.clark@....com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Thomas Richter <tmricht@...ux.ibm.com>
> Cc: John Garry <john.garry@...wei.com>
> 
> James Clark (13):
>   perf tools: Improve topology test
>   perf tools: Use allocator for perf_cpu_map
>   perf tools: Add new struct for cpu aggregation
>   perf tools: Replace aggregation ID with a struct
>   perf tools: add new map type for aggregation
>   perf tools: drop in cpu_aggr_map struct
>   perf tools: restrict visibility of functions
>   perf tools: Start using cpu_aggr_id in map
>   perf tools: Add separate node member
>   perf tools: Add separate socket member
>   perf tools: Add separate die member
>   perf tools: Add separate core member
>   perf tools: add thread field

I sent few comments but overall looks good

Stephane, Andi, could you take a look, please?

thanks,
jirka

> 
>  tools/perf/builtin-stat.c      | 128 +++++++++++++------------
>  tools/perf/tests/topology.c    |  58 +++++++++--
>  tools/perf/util/cpumap.c       | 170 ++++++++++++++++++++++-----------
>  tools/perf/util/cpumap.h       |  55 ++++++-----
>  tools/perf/util/stat-display.c | 106 +++++++++++---------
>  tools/perf/util/stat.c         |   2 +-
>  tools/perf/util/stat.h         |   9 +-
>  7 files changed, 332 insertions(+), 196 deletions(-)
> 
> -- 
> 2.28.0
>