linux-kernel - RE: [PATCH 2/6] drivers: hv: vmbus: Replace symbolic permissions by octal permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB1052E58FC2A195EDB723B2DDD7E40@MW2PR2101MB1052.namprd21.prod.outlook.com>
Date:   Sun, 15 Nov 2020 22:15:01 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Matheus Castello <matheus@...tello.eng.br>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>
CC:     "sashal@...nel.org" <sashal@...nel.org>,
        Tianyu Lan <Tianyu.Lan@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Sunil Muthuswamy <sunilmut@...rosoft.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/6] drivers: hv: vmbus: Replace symbolic permissions by
 octal permissions

From: Matheus Castello <matheus@...tello.eng.br> Sent: Sunday, November 15, 2020 11:58 AM
> 
> This fixed the below checkpatch issue:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
> 
> Signed-off-by: Matheus Castello <matheus@...tello.eng.br>
> ---
>  drivers/hv/vmbus_drv.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 9ed7e3b1d654..52c1407c1849 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1812,7 +1812,7 @@ static ssize_t channel_pending_show(struct vmbus_channel
> *channel,
>  		       channel_pending(channel,
>  				       vmbus_connection.monitor_pages[1]));
>  }
> -static VMBUS_CHAN_ATTR(pending, S_IRUGO, channel_pending_show, NULL);
> +static VMBUS_CHAN_ATTR(pending, 0444, channel_pending_show, NULL);
> 
>  static ssize_t channel_latency_show(struct vmbus_channel *channel,
>  				    char *buf)
> @@ -1821,19 +1821,19 @@ static ssize_t channel_latency_show(struct vmbus_channel
> *channel,
>  		       channel_latency(channel,
>  				       vmbus_connection.monitor_pages[1]));
>  }
> -static VMBUS_CHAN_ATTR(latency, S_IRUGO, channel_latency_show, NULL);
> +static VMBUS_CHAN_ATTR(latency, 0444, channel_latency_show, NULL);
> 
>  static ssize_t channel_interrupts_show(struct vmbus_channel *channel, char *buf)
>  {
>  	return sprintf(buf, "%llu\n", channel->interrupts);
>  }
> -static VMBUS_CHAN_ATTR(interrupts, S_IRUGO, channel_interrupts_show, NULL);
> +static VMBUS_CHAN_ATTR(interrupts, 0444, channel_interrupts_show, NULL);
> 
>  static ssize_t channel_events_show(struct vmbus_channel *channel, char *buf)
>  {
>  	return sprintf(buf, "%llu\n", channel->sig_events);
>  }
> -static VMBUS_CHAN_ATTR(events, S_IRUGO, channel_events_show, NULL);
> +static VMBUS_CHAN_ATTR(events, 0444, channel_events_show, NULL);
> 
>  static ssize_t channel_intr_in_full_show(struct vmbus_channel *channel,
>  					 char *buf)
> @@ -1872,7 +1872,7 @@ static ssize_t subchannel_monitor_id_show(struct
> vmbus_channel *channel,
>  {
>  	return sprintf(buf, "%u\n", channel->offermsg.monitorid);
>  }
> -static VMBUS_CHAN_ATTR(monitor_id, S_IRUGO, subchannel_monitor_id_show, NULL);
> +static VMBUS_CHAN_ATTR(monitor_id, 0444, subchannel_monitor_id_show, NULL);
> 
>  static ssize_t subchannel_id_show(struct vmbus_channel *channel,
>  				  char *buf)
> --
> 2.28.0

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>