linux-kernel - Re: [PATCH v6 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201116094614.035ceffa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 16 Nov 2020 09:46:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Lukasz Stelmach <l.stelmach@...sung.com>
Cc:     Andrew Lunn <andrew@...n.ch>, jim.cromie@...il.com,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v6 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet
 Adapter Driver

On Mon, 16 Nov 2020 16:33:26 +0100 Lukasz Stelmach wrote:
> > Please make sure the new code builds cleanly with W=1 C=1
> >
> > ../drivers/net/ethernet/asix/ax88796c_ioctl.c:221:19: warning: initialized field overwritten [-Woverride-init]
> >   221 |  .get_msglevel  = ax88796c_ethtool_getmsglevel,
> >       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../drivers/net/ethernet/asix/ax88796c_ioctl.c:221:19: note: (near initialization for ‘ax88796c_ethtool_ops.get_msglevel’)
> > ../drivers/net/ethernet/asix/ax88796c_ioctl.c:222:19: warning: initialized field overwritten [-Woverride-init]
> >   222 |  .set_msglevel  = ax88796c_ethtool_setmsglevel,
> >       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../drivers/net/ethernet/asix/ax88796c_ioctl.c:222:19: note: (near initialization for ‘ax88796c_ethtool_ops.set_msglevel’)
> > In file included from ../drivers/net/ethernet/asix/ax88796c_main.h:15,
> >                  from ../drivers/net/ethernet/asix/ax88796c_ioctl.c:16:
> > ../drivers/net/ethernet/asix/ax88796c_spi.h:25:17: warning: ‘tx_cmd_buf’ defined but not used [-Wunused-const-variable=]
> >    25 | static const u8 tx_cmd_buf[4] = {AX_SPICMD_WRITE_TXQ, 0xFF, 0xFF, 0xFF};
> >       |                 ^~~~~~~~~~  
> 
> I fixed the problems reported by W=1, but I am afraid I can't do
> anything about C=1. sparse is is reporting
> 
> [...]
> ./include/linux/atomic-fallback.h:266:16: error: Expected ; at end ofdeclaration
> ./include/linux/atomic-fallback.h:266:16: error: got ret
> ./include/linux/atomic-fallback.h:267:1: error: Expected ; at the end of type declaration
> ./include/linux/atomic-fallback.h:267:1: error: too many errors
> Segmentation fault
> 
> in the headers and gets killed.

That's fine, sparse is wobbly at times, thanks!