[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201116185903.GD4739@sirena.org.uk>
Date: Mon, 16 Nov 2020 18:59:03 +0000
From: Mark Brown <broonie@...nel.org>
To: Tim Harvey <tharvey@...eworks.com>
Cc: Lee Jones <lee.jones@...aro.org>, Tony Lindgren <tony@...mide.com>,
open list <linux-kernel@...r.kernel.org>,
Carl Philipp Klemm <philipp@...s.xyz>,
Laxminath Kasam <lkasam@...eaurora.org>,
Merlijn Wajer <merlijn@...zup.org>,
Pavel Machek <pavel@....cz>, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap
clear_ack
On Fri, Nov 13, 2020 at 02:06:29PM -0800, Tim Harvey wrote:
> asserted? I'm also wondering if my issue is that I currently have the
> interrupt registered as such:
> ret = devm_regmap_add_irq_chip(dev, gsc->regmap, client->irq,
> IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_FALLING, 0, &gsc_irq_chip,
> &irq_data);
> Perhaps this should be IRQF_TRIGGER_LOW as the device will not
> de-assert its IRQ# until all source bits are cleared.
That's clearly an active low interrupt, it will break things if it's
registered as edge triggered.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists