linux-kernel - Re: [PATCH v2] soc: ti: pruss: Fix wrong check against *get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <528e56d5-23d5-9f83-1bf4-a7f786593eae@oracle.com>
Date:   Mon, 16 Nov 2020 11:06:34 -0800
From:   santosh.shilimkar@...cle.com
To:     Suman Anna <s-anna@...com>,
        Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>,
        ssantosh@...nel.org
Cc:     lee.jones@...aro.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        praneeth@...com, tony@...mide.com,
        Wei Yongjun <weiyongjun1@...wei.com>
Subject: Re: [PATCH v2] soc: ti: pruss: Fix wrong check against
 *get_match_data return value

On 11/16/20 9:31 AM, Suman Anna wrote:
> Hi Santosh,
> 
> On 11/16/20 11:22 AM, Grzegorz Jaszczyk wrote:
>> Since the of_device_get_match_data() doesn't return error code, remove
>> wrong IS_ERR test. Proper check against NULL pointer is already done
>> later before usage: if (data && data->...).
>>
>> Additionally, proceeding with empty device data is valid (e.g. in case
>> of "ti,am3356-pruss").
>>
>> Fixes: ba59c9b43c86 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX")
>> Reported-by: Wei Yongjun <weiyongjun1@...wei.com>
>> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
>> Acked-by: Suman Anna <s-anna@...com>
> 
> Can you please pick this up for 5.10-rc's?
> 
Nothing is broken so I will just add these for next merge window.

Regards,
Santosh