linux-kernel - Re: [PATCH net] net/mlx5: fix error return code in mlx5e_tc_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32a6628214621766d884308fd9f29abad9e149b9.camel@kernel.org>
Date:   Mon, 16 Nov 2020 12:05:06 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Wang Hai <wanghai38@...wei.com>, leon@...nel.org,
        davem@...emloft.net, kuba@...nel.org, lariel@...lanox.com,
        roid@...lanox.com
Cc:     linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net/mlx5: fix error return code in
 mlx5e_tc_nic_init()

On Sat, 2020-11-14 at 19:52 +0800, Wang Hai wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic
> flows")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index e3a968e9e2a0..c7ad5db84f78 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -5227,8 +5227,10 @@ int mlx5e_tc_nic_init(struct mlx5e_priv *priv)
>  
>  	tc->ct = mlx5_tc_ct_init(priv, tc->chains, &priv-
> >fs.tc.mod_hdr,
>  				 MLX5_FLOW_NAMESPACE_KERNEL);
> -	if (IS_ERR(tc->ct))
> +	if (IS_ERR(tc->ct)) {
> +		err = PTR_ERR(tc->ct);
>  		goto err_ct;
> +	}
>  
>  	tc->netdevice_nb.notifier_call = mlx5e_tc_netdev_event;
>  	err = register_netdevice_notifier_dev_net(priv->netdev,

Applied to net-mlx5 
Thanks !