linux-kernel - Re: drivers/accessibility/speakup/serialio.c:48:19: warning: variable 'quot' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e18107c14e59672a179b4fe4d9918c311c0aa9e9.camel@decadent.org.uk>
Date:   Mon, 16 Nov 2020 20:39:02 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: drivers/accessibility/speakup/serialio.c:48:19: warning:
 variable 'quot' set but not used

On Mon, 2020-11-16 at 21:33 +0100, Samuel Thibault wrote:
> Ben Hutchings, le lun. 16 nov. 2020 19:51:23 +0000, a ecrit:
> > On Mon, 2020-11-16 at 20:01 +0100, Samuel Thibault wrote:
> > > Perhaps we should rather use
> > > 
> > > depends on ISA || (X86 && COMPILE_TEST)
> > > 
> > > ?
> > > so that we have compile testing on x86 only (where the inb/outb macros
> > > always behave fine) to avoid such issues on other archs?
> > 
> > That seems reasonable though unusual.
> > 
> > > Or we tell the architecture maintainers to fix their out macros into
> > > consuming their parameters?
> > [...]
> > 
> > It does seem odd for parisc to define the I/O functions this way.  I
> > don't know if it's really a bug.
> 
> Sorry I wasn't clear: the problem here is when CONFIG_EISA is disabled,
> the eisa_in/out calls are replaced by BUG() stubs, and the stubs do not
> consume their input:

Yes, I did see that.

Ben.

> arch/parisc/include/asm/io.h
> 
> #if defined(CONFIG_PCI)
> extern void outb(unsigned char b, int addr);
> #elif defined(CONFIG_EISA)
> #define outb eisa_out8
> #else
> #define outb(x, y)	BUG()
> #endif
> 
> Samuel
-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                      - Albert Einstein



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)