linux-kernel - Re: [PATCH v2] net: phy: mscc: fix excluded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Nov 2020 22:15:01 +0100
From:   Antoine Tenart <atenart@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Julia Lawall <julia.lawall@...ia.fr>,
        Russell King <linux@...linux.org.uk>
Cc:     Quentin Schulz <quentin.schulz@...tlin.com>,
        kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Denis Efremov <efremov@...ux.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: phy: mscc: fix excluded_middle.cocci warnings

Hello Julia,

Quoting Julia Lawall (2020-11-16 16:34:44)
> From: kernel test robot <lkp@...el.com>
> 
> Condition !A || A && B is equivalent to !A || B.
> 
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
> 
> Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
> CC: Denis Efremov <efremov@...ux.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>

Reviewed-by: Antoine Tenart <atenart@...nel.org>

Thanks!
Antoine

> ---
> 
> v2: add netdev mailing list
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   e28c0d7c92c89016c12a677616668957351e7542
> commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add excluded_middle.cocci script
> :::::: branch date: 8 hours ago
> :::::: commit date: 8 weeks ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  mscc_ptp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/net/phy/mscc/mscc_ptp.c
> +++ b/drivers/net/phy/mscc/mscc_ptp.c
> @@ -136,7 +136,7 @@ static void vsc85xx_ts_write_csr(struct
> 
>         phy_ts_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_1588);
> 
> -       if (!cond || (cond && upper))
> +       if (!cond || upper)
>                 phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_MSB, upper);
> 
>         phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_LSB, lower);