[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201116232221.GS917484@nvidia.com>
Date: Mon, 16 Nov 2020 19:22:21 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Thomas Gleixner <tglx@...utronix.de>
CC: Ziyad Atiyyeh <ziyadat@...dia.com>,
Itay Aveksis <itayav@...dia.com>,
Moshe Shemesh <moshe@...dia.com>,
LKML <linux-kernel@...r.kernel.org>, <x86@...nel.org>,
Joerg Roedel <joro@...tes.org>,
<iommu@...ts.linux-foundation.org>, <linux-pci@...r.kernel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Marc Zyngier <maz@...nel.org>,
David Woodhouse <dwmw2@...radead.org>
Subject: Re: iommu/vt-d: Cure VF irqdomain hickup
On Thu, Nov 12, 2020 at 08:15:02PM +0100, Thomas Gleixner wrote:
> The recent changes to store the MSI irqdomain pointer in struct device
> missed that Intel DMAR does not register virtual function devices. Due to
> that a VF device gets the plain PCI-MSI domain assigned and then issues
> compat MSI messages which get caught by the interrupt remapping unit.
>
> Cure that by inheriting the irq domain from the physical function
> device.
>
> That's a temporary workaround. The correct fix is to inherit the irq domain
> from the bus, but that's a larger effort which needs quite some other
> changes to the way how x86 manages PCI and MSI domains.
>
> Fixes: 85a8dfc57a0b ("iommm/vt-d: Store irq domain in struct device")
> Reported-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
> drivers/iommu/intel/dmar.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
Our QA says it solves the issue:
Tested-by: Itay Aveksis <itayav@...dia.com>
Thanks,
Jason
Powered by blists - more mailing lists