linux-kernel - Re: [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a20145ef-31a1-a72d-2d60-87a5282ace87@connolly.tech>
Date:   Mon, 16 Nov 2020 23:49:32 +0000
From:   Caleb Connolly <caleb@...nolly.tech>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices

On 2020-11-16 22:01, Pavel Machek wrote:
> Hi!
>
>> Add initial support for the OnePlus 6 (enchilada) and 6T (fajita) based
>> on the sdm845-mtp DT. Support includes:
>>
>> * Display panels and Adreno 630
>> * Touch screen support with synaptics rmi4
>> * All remoteprocs start correctly
>> * WLAN / Bluetooth
>> * Volume / power buttons and OnePlus Tri-State switch are functional
>>      The tri-state switch is a 3 state mute slider on the side of the phone * USB
>> support, currently forced to peripheral as type C detection isn't functional.
> I have similar switches on my joystick... but I don't believe modelling it as 3 separate
> keys with "macro" keysym is the right way to go.

Hi! I agree that this is a bit of a weird way to model the switch, do 
you have any ideas for a better solution?

I'm happy to drop this from the patch for now and come up with a better 
method down the line.

Regards,

Caleb

>> +		state-top {
>> +			label = "Tri-state key top";
>> +			linux,code = <KEY_MACRO1>;
>> +			interrupt-parent = <&tlmm>;
>> +			interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
>> +			debounce-interval = <500>;
>> +			linux,can-disable;
>> +		};
>> +
>> +		state-middle {
>> +			label = "Tri-state key middle";
>> +			linux,code = <KEY_MACRO2>;
>> +			interrupt-parent = <&tlmm>;
>> +			interrupts = <52 IRQ_TYPE_EDGE_FALLING>;
>> +			debounce-interval = <500>;
>> +			linux,can-disable;
>> +		};
>> +
>> +		state-bottom {
>> +			label = "Tri-state key bottom";
>> +			linux,code = <KEY_MACRO3>;
>> +			interrupt-parent = <&tlmm>;
>> +			interrupts = <126 IRQ_TYPE_EDGE_FALLING>;
>> +			debounce-interval = <500>;
>> +			linux,can-disable;
>> +		};
> Best regards,
> 									Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html