lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Nov 2020 08:30:10 +0100 From: Christian Borntraeger <borntraeger@...ibm.com> To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org Cc: Mikulas Patocka <mpatocka@...hat.com>, Alasdair Kergon <agk@...hat.com>, Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, linux-s390@...r.kernel.org Subject: Re: [PATCH] md: dm-writeback: add __noreturn to BUG-ging function On 13.11.20 23:52, Randy Dunlap wrote: > Building on arch/s390/ flags this as an error, so add the > __noreturn attribute modifier to prevent the build error. > > cc1: some warnings being treated as errors > ../drivers/md/dm-writecache.c: In function 'persistent_memory_claim': > ../drivers/md/dm-writecache.c:323:1: error: no return statement in function returning non-void [-Werror=return-type] ok with me, but I am asking why the unreachable macro is not good enough. For x86 it obviously is. form arch/s390/include/asm/bug.h #define BUG() do { \ __EMIT_BUG(0); \ unreachable(); \ } while (0) > > Fixes: 48debafe4f2f ("dm: add writecache target") > Signed-off-by: Randy Dunlap <rdunlap@...radead.org> > Cc: Mikulas Patocka <mpatocka@...hat.com> > Cc: Alasdair Kergon <agk@...hat.com> > Cc: Mike Snitzer <snitzer@...hat.com> > Cc: dm-devel@...hat.com > Cc: Heiko Carstens <hca@...ux.ibm.com> > Cc: Vasily Gorbik <gor@...ux.ibm.com> > Cc: Christian Borntraeger <borntraeger@...ibm.com> > Cc: linux-s390@...r.kernel.org > --- > drivers/md/dm-writecache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20201113.orig/drivers/md/dm-writecache.c > +++ linux-next-20201113/drivers/md/dm-writecache.c > @@ -317,7 +317,7 @@ err1: > return r; > } > #else > -static int persistent_memory_claim(struct dm_writecache *wc) > +static int __noreturn persistent_memory_claim(struct dm_writecache *wc) > { > BUG(); > } >
Powered by blists - more mailing lists