linux-kernel - Re: [PATCH] usb: typec: qcom-pmic-typec: fix builtin build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201116082924.GA3124021@kuha.fi.intel.com>
Date:   Mon, 16 Nov 2020 10:29:24 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        linux-usb@...r.kernel.org, Wesley Cheng <wcheng@...eaurora.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] usb: typec: qcom-pmic-typec: fix builtin build errors

On Sun, Nov 15, 2020 at 08:06:53PM -0800, Randy Dunlap wrote:
> Fix build errors when CONFIG_TYPEC_QCOM_PMIC=y and
> CONFIG_USB_ROLE_SWITCH=m by limiting the former to =m when
> USB_ROLE_SWITCH also =m.
> 
> powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_remove':
> qcom-pmic-typec.c:(.text+0x28): undefined reference to `.usb_role_switch_set_role'
> powerpc64-linux-ld: qcom-pmic-typec.c:(.text+0x64): undefined reference to `.usb_role_switch_put'
> powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_check_connection':
> qcom-pmic-typec.c:(.text+0x120): undefined reference to `.usb_role_switch_set_role'
> powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_probe':
> qcom-pmic-typec.c:(.text+0x360): undefined reference to `.fwnode_usb_role_switch_get'
> powerpc64-linux-ld: qcom-pmic-typec.c:(.text+0x4e4): undefined reference to `.usb_role_switch_put'
> 
> Fixes: 6c8cf3695176 ("usb: typec: Add QCOM PMIC typec detection driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: linux-usb@...r.kernel.org
> Cc: Wesley Cheng <wcheng@...eaurora.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20201113.orig/drivers/usb/typec/Kconfig
> +++ linux-next-20201113/drivers/usb/typec/Kconfig
> @@ -88,6 +88,7 @@ config TYPEC_STUSB160X
>  config TYPEC_QCOM_PMIC
>  	tristate "Qualcomm PMIC USB Type-C driver"
>  	depends on ARCH_QCOM || COMPILE_TEST
> +	depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
>  	help
>  	  Driver for supporting role switch over the Qualcomm PMIC.  This will
>  	  handle the USB Type-C role and orientation detection reported by the

-- 
heikki