linux-kernel - Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Nov 2020 08:40:23 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Eric Anholt <eric@...olt.net>, David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static

On Sat, 14 Nov 2020, Sam Ravnborg wrote:

> Hi Lee,
> On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> > 
> > Cc: Eric Anholt <eric@...olt.net>
> > Cc: David Airlie <airlied@...ux.ie>
> > Cc: Daniel Vetter <daniel@...ll.ch>
> > Cc: dri-devel@...ts.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> Eric's was not copied on this or the other pl111 patch.
> Added Eric so he can be aware of this fix.

Eric Anholt?

He's on Cc?

> > ---
> >  drivers/gpu/drm/pl111/pl111_display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> > index b3e8697cafcf1..69c02e7c82b7e 100644
> > --- a/drivers/gpu/drm/pl111/pl111_display.c
> > +++ b/drivers/gpu/drm/pl111/pl111_display.c
> > @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe,
> >  		drm_crtc_vblank_on(crtc);
> >  }
> >  
> > -void pl111_display_disable(struct drm_simple_display_pipe *pipe)
> > +static void pl111_display_disable(struct drm_simple_display_pipe *pipe)
> >  {
> >  	struct drm_crtc *crtc = &pipe->crtc;
> >  	struct drm_device *drm = crtc->dev;

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog