linux-kernel - Re: bitmap: Remove unused function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201116100046.GS4077@smile.fi.intel.com>
Date:   Mon, 16 Nov 2020 12:00:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     "Ma, Jianpeng" <jianpeng.ma@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: bitmap: Remove unused function declaration

On Sun, Nov 15, 2020 at 07:59:37PM -0800, Yury Norov wrote:
> (CC related people)
> 
> Since there is no actual implementation for them, there's , I think
> it's safe (and better)
> to remove the declarations. Thanks for the catch.

Fixes: 2afe27c718b6 ("lib/bitmap.c: bitmap_[empty,full]: remove code duplication")

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Acked-by: Yury Norov <yury.norov@...il.com>
> 
> On Sun, Nov 15, 2020 at 7:17 PM Ma, Jianpeng <jianpeng.ma@...el.com> wrote:
> >
> > Signed-off-by: Jianpeng Ma <jianpeng.ma@...el.com>
> > ---
> >  include/linux/bitmap.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> > index 99058eb81042..6f08965c69a5 100644
> > --- a/include/linux/bitmap.h
> > +++ b/include/linux/bitmap.h
> > @@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
> >   * lib/bitmap.c provides these functions:
> >   */
> >
> > -extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
> > -extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
> >  extern int __bitmap_equal(const unsigned long *bitmap1,
> >                           const unsigned long *bitmap2, unsigned int nbits);
> >  extern bool __pure __bitmap_or_equal(const unsigned long *src1,
> > --
> > 2.28.0

-- 
With Best Regards,
Andy Shevchenko