linux-kernel - Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffEkMahL5Fw6w6izwOu2wh3RqAebm9-N3KCadS2N177rLKg@mail.gmail.com>
Date:   Mon, 16 Nov 2020 11:44:52 +0100
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'

On Mon, Nov 16, 2020 at 11:41 AM Lee Jones <lee.jones@...aro.org> wrote:
>
> Hasn't been used since 2009.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’:
>  drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]
>
> Cc: Jack Wang <jinpu.wang@...ud.ionos.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Acked-by: Jack Wang <jinpu.wang@...ud.ionos.com>
Thanks Lee.
> ---
>  drivers/scsi/pm8001/pm8001_hwi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
> index 2054c2b03d928..0a1e09b1cd580 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -416,7 +416,7 @@ int pm8001_bar4_shift(struct pm8001_hba_info *pm8001_ha, u32 shiftValue)
>  static void mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha,
>                                      u32 SSCbit)
>  {
> -       u32 value, offset, i;
> +       u32 offset, i;
>         unsigned long flags;
>
>  #define SAS2_SETTINGS_LOCAL_PHY_0_3_SHIFT_ADDR 0x00030000
> @@ -467,7 +467,7 @@ static void mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha,
>         so that the written value will be 0x8090c016.
>         This will ensure only down-spreading SSC is enabled on the SPC.
>         *************************************************************/
> -       value = pm8001_cr32(pm8001_ha, 2, 0xd8);
> +       pm8001_cr32(pm8001_ha, 2, 0xd8);
>         pm8001_cw32(pm8001_ha, 2, 0xd8, 0x8000C016);
>
>         /*set the shifted destination address to 0x0 to avoid error operation */
> --
> 2.25.1
>