linux-kernel - Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201116111850.GA68743@ravnborg.org>
Date:   Mon, 16 Nov 2020 12:18:50 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static

Hi Lee,
On Mon, Nov 16, 2020 at 10:25:30AM +0000, Lee Jones wrote:
> On Mon, 16 Nov 2020, Sam Ravnborg wrote:
> 
> > Hi Lee,
> > On Mon, Nov 16, 2020 at 08:40:23AM +0000, Lee Jones wrote:
> > > On Sat, 14 Nov 2020, Sam Ravnborg wrote:
> > > 
> > > > Hi Lee,
> > > > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> > > > > Fixes the following W=1 kernel build warning(s):
> > > > > 
> > > > >  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> > > > > 
> > > > > Cc: Eric Anholt <eric@...olt.net>
> > > > > Cc: David Airlie <airlied@...ux.ie>
> > > > > Cc: Daniel Vetter <daniel@...ll.ch>
> > > > > Cc: dri-devel@...ts.freedesktop.org
> > > > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > > > 
> > > > Eric's was not copied on this or the other pl111 patch.
> > > > Added Eric so he can be aware of this fix.
> > > 
> > > Eric Anholt?
> > > 
> > > He's on Cc?
> > Not on the original mail I received.
> 
> Looks fine to me:
> 
> Date: Fri, 13 Nov 2020 13:49:10 +0000
> From: Lee Jones <lee.jones@...aro.org>
> To: lee.jones@...aro.org
> Cc: linux-kernel@...r.kernel.org, Eric Anholt <eric@...olt.net>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org
> Subject: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
> 
> Also reflected in Gmail:
> 
>  https://i.imgur.com/d69YTzz.png

Strange indeed. In lore Eric is not included:
https://lore.kernel.org/dri-devel/20201113134938.4004947-13-lee.jones@linaro.org/

I consider this a fluke in the force, and will not worry more about it.

	Sam