linux-kernel - Re: [PATCH v4 14/27] completion: fix kernel-doc markups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201116113605.GB3121378@hirez.programming.kicks-ass.net>
Date:   Mon, 16 Nov 2020 12:36:05 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        "Joel Fernandes (Google)" <joel@...lfernandes.org>,
        Jonathan Corbet <corbet@....net>,
        Davidlohr Bueso <dbueso@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 14/27] completion: fix kernel-doc markups

On Mon, Nov 16, 2020 at 11:18:10AM +0100, Mauro Carvalho Chehab wrote:
> Kernel-doc only supports having the comment just before
> the identifier.
> 
> The markup for init_completion is actually for
> __init_completion.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> 
> ---
> 
> Thats said, IMHO, it would make sense to simply
> rename __init_completion() to init_completion() and drop
> this define:
> 
> 	 #define init_completion(x) __init_completion(x)

Yeah, that seems to be the result of much code shuffling. That cleanups
seems sanest.