linux-kernel - Re: [PATCH RFC 11/12] vringh: allow vringh_iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201116114854.5vrcjzsvhklpfeud@steredhat>
Date:   Mon, 16 Nov 2020 12:48:54 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     virtualization@...ts.linux-foundation.org,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Laurent Vivier <lvivier@...hat.com>,
        linux-kernel@...r.kernel.org, Eli Cohen <elic@...dia.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Max Gurtovoy <mgurtovoy@...dia.com>
Subject: Re: [PATCH RFC 11/12] vringh: allow vringh_iov_xfer() to skip bytes
 when ptr is NULL

On Mon, Nov 16, 2020 at 12:32:02PM +0800, Jason Wang wrote:
>
>On 2020/11/13 下午9:47, Stefano Garzarella wrote:
>>In some cases, it may be useful to provide a way to skip a number
>>of bytes in a vringh_iov.
>>
>>In order to keep vringh_iov consistent, let's reuse vringh_iov_xfer()
>>logic and skip bytes when the ptr is NULL.
>>
>>Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
>>---
>>
>>I'm not sure if this is the best option, maybe we can add a new
>>function vringh_iov_skip().
>>
>>Suggestions?
>
>
>I might be worth to check whether we can convert vringh_iov to use iov 
>iterator then we can use iov_iterator_advance() here.

Make sense, I'll take a look.

Thanks for the suggestion,
Stefano