[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAKGbVbv4q7iwNe6g708_NXRGQ5zkQurR6AC82QrNL3eFPihqSQ@mail.gmail.com>
Date: Mon, 16 Nov 2020 08:24:21 +0800
From: Qiang Yu <yuq825@...il.com>
To: Liu Shixin <liushixin2@...wei.com>
Cc: David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
dri-devel <dri-devel@...ts.freedesktop.org>,
lima@...ts.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/lima: simplify the return expression of lima_devfreq_target
Applied to drm-misc-next.
On Sat, Sep 19, 2020 at 6:43 PM Qiang Yu <yuq825@...il.com> wrote:
>
> Looks good for me, patch is:
> Reviewed-by: Qiang Yu <yuq825@...il.com>
>
> Regards,
> Qiang
>
> On Sat, Sep 19, 2020 at 5:47 PM Liu Shixin <liushixin2@...wei.com> wrote:
> >
> > Simplify the return expression.
> >
> > Signed-off-by: Liu Shixin <liushixin2@...wei.com>
> > ---
> > drivers/gpu/drm/lima/lima_devfreq.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c
> > index bbe02817721b..5914442936ed 100644
> > --- a/drivers/gpu/drm/lima/lima_devfreq.c
> > +++ b/drivers/gpu/drm/lima/lima_devfreq.c
> > @@ -35,18 +35,13 @@ static int lima_devfreq_target(struct device *dev, unsigned long *freq,
> > u32 flags)
> > {
> > struct dev_pm_opp *opp;
> > - int err;
> >
> > opp = devfreq_recommended_opp(dev, freq, flags);
> > if (IS_ERR(opp))
> > return PTR_ERR(opp);
> > dev_pm_opp_put(opp);
> >
> > - err = dev_pm_opp_set_rate(dev, *freq);
> > - if (err)
> > - return err;
> > -
> > - return 0;
> > + return dev_pm_opp_set_rate(dev, *freq);
> > }
> >
> > static void lima_devfreq_reset(struct lima_devfreq *devfreq)
> > --
> > 2.25.1
> >
Powered by blists - more mailing lists