linux-kernel - [PATCH] auxdisplay: panel: Fix missing print function pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201116132155.555489-1-poeschel@lemonage.de>
Date:   Mon, 16 Nov 2020 14:21:55 +0100
From:   poeschel@...onage.de
To:     Willy Tarreau <willy@...roxy.com>,
        Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        Lars Poeschel <poeschel@...onage.de>,
        linux-kernel@...r.kernel.org (open list)
Cc:     kernel test robot <oliver.sang@...el.com>
Subject: [PATCH] auxdisplay: panel: Fix missing print function pointer

From: Lars Poeschel <poeschel@...onage.de>

charlcd drivers need to provide some print function to charlcd. For
hd44780 based panel driver this function was missing. We provide the
generic hd44780_common_print function which should be suitable.

Fixes: b26deabb1d915fe87d395081bbd3058b938dee89 ("auxdisplay: hd44780_common_print")
Reported-by: kernel test robot <oliver.sang@...el.com>
Signed-off-by: Lars Poeschel <poeschel@...onage.de>
---
 drivers/auxdisplay/panel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index e07fadac281d..36848e464d1f 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -810,6 +810,7 @@ static void lcd_write_data_tilcd(struct hd44780_common *hdc, int data)
 
 static const struct charlcd_ops charlcd_serial_ops = {
 	.backlight	= lcd_backlight,
+	.print		= hd44780_common_print,
 	.gotoxy		= hd44780_common_gotoxy,
 	.home		= hd44780_common_home,
 	.clear_display	= hd44780_common_clear_display,
@@ -826,6 +827,7 @@ static const struct charlcd_ops charlcd_serial_ops = {
 
 static const struct charlcd_ops charlcd_parallel_ops = {
 	.backlight	= lcd_backlight,
+	.print		= hd44780_common_print,
 	.gotoxy		= hd44780_common_gotoxy,
 	.home		= hd44780_common_home,
 	.clear_display	= hd44780_common_clear_display,
@@ -842,6 +844,7 @@ static const struct charlcd_ops charlcd_parallel_ops = {
 
 static const struct charlcd_ops charlcd_tilcd_ops = {
 	.backlight	= lcd_backlight,
+	.print		= hd44780_common_print,
 	.gotoxy		= hd44780_common_gotoxy,
 	.home		= hd44780_common_home,
 	.clear_display	= hd44780_common_clear_display,
-- 
2.29.2