linux-kernel - Re: [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <07558590-438a-4347-820e-c117b19dac20@www.fastmail.com>
Date:   Mon, 16 Nov 2020 14:40:55 +1030
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Dan Carpenter" <dan.carpenter@...cle.com>,
        "Joel Stanley" <joel@....id.au>
Cc:     "Tom Rix" <trix@...hat.com>, linux-aspeed@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo_init()



On Fri, 13 Nov 2020, at 20:38, Dan Carpenter wrote:
> This needs to call of_node_put(np) before returning if of_iomap() fails.
> 
> Fixes: e0218dca5787 ("soc: aspeed: Add soc info driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Andrew Jeffery <andrew@...id.au>