linux-kernel - RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB2876BB714DF701E81866B13EB8E30@DM6PR11MB2876.namprd11.prod.outlook.com>
Date:   Mon, 16 Nov 2020 14:22:32 +0000
From:   "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@...el.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        "Raja Subramanian, Lakshmi Bai" 
        <lakshmi.bai.raja.subramanian@...el.com>,
        "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@...el.com>,
        "David E. Box" <david.e.box@...ux.intel.com>
Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem
 Bay SOC

Hi Ulf,

Thanks for your review comments. I replied inline

>-----Original Message-----
>From: Ulf Hansson <ulf.hansson@...aro.org>
>Sent: Monday, November 16, 2020 7:41 PM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>
>Cc: linux-mmc@...r.kernel.org; Linux ARM <linux-arm-
>kernel@...ts.infradead.org>; Linux Kernel Mailing List <linux-
>kernel@...r.kernel.org>; Hunter, Adrian <adrian.hunter@...el.com>; Raja
>Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@...el.com>; Wan
>Mohamad, Wan Ahmad Zainie
><wan.ahmad.zainie.wan.mohamad@...el.com>; David E. Box
><david.e.box@...ux.intel.com>
>Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem
>Bay SOC
>
>On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@...el.com> wrote:
>>
>> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>
>>
>> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations
>> handling") introduces platform specific SDHCI clock operation.
>>
>> This patch declares the clock operation for Keem Bay.
>> Add clk_ops for SD, EMMC and SDIO operations.
>
>The above commit message doesn't really tell why or what goes on here.
>Can please try to clarify that.

We missed out the clock operation handling patch (Commit 16ada730a759)
and did not handle the clk_ops  for Keem Bay SOC devices. 
These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86)  are merged at around the same time.
We catch the issue later when trying to boot into v5.10-rc1 with Keem Bay EVM.
That is why I created this patch to handle the clk_ops for Keem Bay devices.

>
>>
>> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem
>> Bay")
>
>Is $subject patch fixing a bug/regression?

This is to fix issue on previous commit. It is a bug fix.

>
>Kind regards
>Uffe
>
>>
>> Signed-off-by: Muhammad Husaini Zulkifli
>> <muhammad.husaini.zulkifli@...el.com>
>> Reviewed-by: Adrian Hunter <adrian.hunter@...el.com>
>> ---
>>  drivers/mmc/host/sdhci-of-arasan.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c
>> b/drivers/mmc/host/sdhci-of-arasan.c
>> index 829ccef87426..012d52e1abee 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data
>> sdhci_arasan_versal_data = {  static struct sdhci_arasan_of_data
>intel_keembay_emmc_data = {
>>         .soc_ctl_map = &intel_keembay_soc_ctl_map,
>>         .pdata = &sdhci_keembay_emmc_pdata,
>> +       .clk_ops = &arasan_clk_ops,
>>  };
>>
>>  static struct sdhci_arasan_of_data intel_keembay_sd_data = {
>>         .soc_ctl_map = &intel_keembay_soc_ctl_map,
>>         .pdata = &sdhci_keembay_sd_pdata,
>> +       .clk_ops = &arasan_clk_ops,
>>  };
>>
>>  static struct sdhci_arasan_of_data intel_keembay_sdio_data = {
>>         .soc_ctl_map = &intel_keembay_soc_ctl_map,
>>         .pdata = &sdhci_keembay_sdio_pdata,
>> +       .clk_ops = &arasan_clk_ops,
>>  };
>>
>>  static const struct of_device_id sdhci_arasan_of_match[] = {
>> --
>> 2.17.1
>>