linux-kernel - Re: linux-next: Signed-off-by missing for commit in the fpga tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X7HGzW8kvimYCUO9@epycbox.lan>
Date:   Sun, 15 Nov 2020 16:24:45 -0800
From:   Moritz Fischer <mdf@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Moritz Fischer <mdf@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the fpga tree

On Mon, Nov 16, 2020 at 09:52:40AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   aaf8fe39c952 ("Revert "fpga: dfl: fix the definitions of type & feature_id for dfl devices"")
>   9922e71f43ac ("Revert "fpga: dfl: move dfl_device_id to mod_devicetable.h"")
>   3ae706b58b0b ("Revert "fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()"")
>   dd57ca7ddec5 ("Revert "fpga: dfl: move dfl bus related APIs to include/linux/dfl.h"")
> 
> are missing a Signed-off-by from their author and committer.
> 
> Reverts are commits, too.  It is also very useful for the commit message
> of a revert to contain some reason(s) for the revert as this may help
> future developers.
> 
> -- 
> Cheers,
> Stephen Rothwell

Sorry, thanks for catching that, for posterity the reason was
that Greg had some further comments and didn't take the pull-request
as-is, so I wanted to have the next-tree reflect that.

I'll be more careful next time,

- Moritz