linux-kernel - Re: [PATCH v4 27/27] scripts: kernel-doc: validate kernel-doc markup with the actual names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Nov 2020 23:06:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jonathan Corbet <corbet@....net>
Cc:     kbuild-all@...ts.01.org, linux-media@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 27/27] scripts: kernel-doc: validate kernel-doc markup
 with the actual names

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20201116]
[cannot apply to drm-intel/for-linux-next s390/features tip/timers/core tip/irq/core tip/sched/core linus/master hnaz-linux-mm/master v5.10-rc4 v5.10-rc3 v5.10-rc2 v5.10-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/net-phy-fix-kernel-doc-markups/20201116-191847
base:    034307507118f7e1b18f8403c85af2216da2dc94
config: nios2-randconfig-r022-20201116 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/11cd9cdaab434fff7a5edbee8d8d4ce9ef11acf4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mauro-Carvalho-Chehab/net-phy-fix-kernel-doc-markups/20201116-191847
        git checkout 11cd9cdaab434fff7a5edbee8d8d4ce9ef11acf4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/batman-adv/multicast.c:840: warning: expecting prototype for batadv_mcast_flags_logs(). Prototype was for batadv_mcast_flags_log() instead

vim +840 net/batman-adv/multicast.c

72f7b2deafde895 Linus Lüssing  2016-05-10  830  
72f7b2deafde895 Linus Lüssing  2016-05-10  831  /**
7e9a8c2ce7c5f87 Sven Eckelmann 2017-12-02  832   * batadv_mcast_flags_logs() - output debug information about mcast flag changes
72f7b2deafde895 Linus Lüssing  2016-05-10  833   * @bat_priv: the bat priv with all the soft interface information
6bc4544021f8228 Linus Lüssing  2019-05-07  834   * @flags: TVLV flags indicating the new multicast state
72f7b2deafde895 Linus Lüssing  2016-05-10  835   *
bccb48c89fe3c09 Sven Eckelmann 2020-06-01  836   * Whenever the multicast TVLV flags this node announces change, this function
bccb48c89fe3c09 Sven Eckelmann 2020-06-01  837   * should be used to notify userspace about the change.
72f7b2deafde895 Linus Lüssing  2016-05-10  838   */
72f7b2deafde895 Linus Lüssing  2016-05-10  839  static void batadv_mcast_flags_log(struct batadv_priv *bat_priv, u8 flags)
72f7b2deafde895 Linus Lüssing  2016-05-10 @840  {
6bc4544021f8228 Linus Lüssing  2019-05-07  841  	bool old_enabled = bat_priv->mcast.mla_flags.enabled;
6bc4544021f8228 Linus Lüssing  2019-05-07  842  	u8 old_flags = bat_priv->mcast.mla_flags.tvlv_flags;
61caf3d109f5411 Linus Lüssing  2019-06-11  843  	char str_old_flags[] = "[.... . ]";
72f7b2deafde895 Linus Lüssing  2016-05-10  844  
61caf3d109f5411 Linus Lüssing  2019-06-11  845  	sprintf(str_old_flags, "[%c%c%c%s%s]",
72f7b2deafde895 Linus Lüssing  2016-05-10  846  		(old_flags & BATADV_MCAST_WANT_ALL_UNSNOOPABLES) ? 'U' : '.',
72f7b2deafde895 Linus Lüssing  2016-05-10  847  		(old_flags & BATADV_MCAST_WANT_ALL_IPV4) ? '4' : '.',
61caf3d109f5411 Linus Lüssing  2019-06-11  848  		(old_flags & BATADV_MCAST_WANT_ALL_IPV6) ? '6' : '.',
61caf3d109f5411 Linus Lüssing  2019-06-11  849  		!(old_flags & BATADV_MCAST_WANT_NO_RTR4) ? "R4" : ". ",
61caf3d109f5411 Linus Lüssing  2019-06-11  850  		!(old_flags & BATADV_MCAST_WANT_NO_RTR6) ? "R6" : ". ");
72f7b2deafde895 Linus Lüssing  2016-05-10  851  
72f7b2deafde895 Linus Lüssing  2016-05-10  852  	batadv_dbg(BATADV_DBG_MCAST, bat_priv,
61caf3d109f5411 Linus Lüssing  2019-06-11  853  		   "Changing multicast flags from '%s' to '[%c%c%c%s%s]'\n",
6bc4544021f8228 Linus Lüssing  2019-05-07  854  		   old_enabled ? str_old_flags : "<undefined>",
72f7b2deafde895 Linus Lüssing  2016-05-10  855  		   (flags & BATADV_MCAST_WANT_ALL_UNSNOOPABLES) ? 'U' : '.',
72f7b2deafde895 Linus Lüssing  2016-05-10  856  		   (flags & BATADV_MCAST_WANT_ALL_IPV4) ? '4' : '.',
61caf3d109f5411 Linus Lüssing  2019-06-11  857  		   (flags & BATADV_MCAST_WANT_ALL_IPV6) ? '6' : '.',
61caf3d109f5411 Linus Lüssing  2019-06-11  858  		   !(flags & BATADV_MCAST_WANT_NO_RTR4) ? "R4" : ". ",
61caf3d109f5411 Linus Lüssing  2019-06-11  859  		   !(flags & BATADV_MCAST_WANT_NO_RTR6) ? "R6" : ". ");
72f7b2deafde895 Linus Lüssing  2016-05-10  860  }
72f7b2deafde895 Linus Lüssing  2016-05-10  861  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (21051 bytes)