linux-kernel - Re: [PATCH v2 1/5] dt-bindings: interrupt-controller: convert icpu intr bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8736196zyt.fsf@BL-laptop>
Date:   Mon, 16 Nov 2020 17:14:34 +0100
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Lars Povlsen <lars.povlsen@...rochip.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Steen.Hegelund@...rochip.com,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Marc Zyngier <maz@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jason Cooper <jason@...edaemon.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: interrupt-controller: convert icpu intr bindings to json-schema

Hello Rob,

> On Thu, 12 Nov 2020 17:04:20 +0100, Gregory CLEMENT wrote:
>> Convert device tree bindings for Microsemi Ocelot SoC ICPU Interrupt
>> Controller to YAML format
>> 
>> Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
>> ---
>>  .../mscc,ocelot-icpu-intr.txt                 | 21 -------
>>  .../mscc,ocelot-icpu-intr.yaml                | 59 +++++++++++++++++++
>>  2 files changed, 59 insertions(+), 21 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.txt
>>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.yaml
>> 
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.yaml:59:4: [error] no new line character at the end of file (new-line-at-end-of-file)
>
> dtschema/dtc warnings/errors:
> make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
> make: *** [Makefile:1364: dt_binding_check] Error 2
>
>
> See https://patchwork.ozlabs.org/patch/1399077
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:

I actually ran 'make dt_binding_check' and in the documentation there
was no reference of Documentation/devicetree/writing-schema.rst the need
of 'yamllint' while in the dependencies section of it was mentioned the
need of 'libyaml-dev'.

What do you think about updating the documentation ?

>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.

Sure I am doing it right now.

Gregory


>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com