linux-kernel - Re: [PATCH] soc: ti: pruss: Remove wrong check against *get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMxfBF4SJsPYZqr5nB4puQAFPGWh6X-L6ty027dAJgdUvy9EZw@mail.gmail.com>
Date:   Mon, 16 Nov 2020 18:17:37 +0100
From:   Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
To:     Suman Anna <s-anna@...com>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        "Bajjuri, Praneeth" <praneeth@...com>, tony@...mide.com,
        Wei Yongjun <weiyongjun1@...wei.com>
Subject: Re: [PATCH] soc: ti: pruss: Remove wrong check against
 *get_match_data return value

Hi Suman,

On Tue, 10 Nov 2020 at 21:43, Suman Anna <s-anna@...com> wrote:
>
> Hi Greg,
>
> On 10/26/20 9:49 AM, Grzegorz Jaszczyk wrote:
> > Since the of_device_get_match_data() doesn't return error code, remove
> > wrong IS_ERR test. Proper check against NULL pointer is already done
> > later before usage: if (data && data->...).
> >
> > Additionally, proceeding with empty device data is valid (e.g. in case
> > of "ti,am3356-pruss").
> >
> > Reported-by: Wei Yongjun <weiyongjun1@...wei.com>
>
> Please add the appropriate Fixes: tag.
>
> And prefer %s/Remove/Fix/ in patch title.

Sure.

>
> With that,
> Acked-by: Suman Anna <s-anna@...com>

Thank you, I will post v2 with all improvements soon.
Best regards,
Grzegorz