linux-kernel - Re: [PATCH 1/3] lib: Introduce copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Nov 2020 17:24:35 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Zhaoxiu Zeng <zengzhaoxiu@....com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
Subject: Re: [PATCH 1/3] lib: Introduce copy_from_back()

> +#define FAST_COPY_SAFEGUARD_SIZE (sizeof(long) * 2 - 1)
> +
> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
> +
> +/*
> + * The caller must ensure that the output buffer has enough space (len + FAST_COPY_SAFEGUARD_SIZE),
> + * so we can write 2 words per loop without overflowing the output buffer
> + */
> +static __always_inline u8 *copy_from_back_fast(u8 *out, size_t dist, size_t len)

The code is pretty unreadable with these longs lines.  Please stick to
the normal 80 char limit.