linux-kernel - Re: [PATCH] ipmi/watchdog: replace atomic_add() and atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201117131431.GF3710@minyard.net>
Date:   Tue, 17 Nov 2020 07:14:31 -0600
From:   Corey Minyard <minyard@....org>
To:     Yejune Deng <yejune.deng@...il.com>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi/watchdog: replace atomic_add() and atomic_sub()

On Mon, Nov 16, 2020 at 03:30:07PM +0800, Yejune Deng wrote:
> atomic_inc() and atomic_dec() looks better

Yes, that's a little neater.  Queued for next release.

Thanks,

-corey

> 
> Signed-off-by: Yejune Deng <yejune.deng@...il.com>
> ---
>  drivers/char/ipmi/ipmi_watchdog.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index f78156d..32c334e 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -495,7 +495,7 @@ static void panic_halt_ipmi_heartbeat(void)
>  	msg.cmd = IPMI_WDOG_RESET_TIMER;
>  	msg.data = NULL;
>  	msg.data_len = 0;
> -	atomic_add(1, &panic_done_count);
> +	atomic_inc(&panic_done_count);
>  	rv = ipmi_request_supply_msgs(watchdog_user,
>  				      (struct ipmi_addr *) &addr,
>  				      0,
> @@ -505,7 +505,7 @@ static void panic_halt_ipmi_heartbeat(void)
>  				      &panic_halt_heartbeat_recv_msg,
>  				      1);
>  	if (rv)
> -		atomic_sub(1, &panic_done_count);
> +		atomic_dec(&panic_done_count);
>  }
>  
>  static struct ipmi_smi_msg panic_halt_smi_msg = {
> @@ -529,12 +529,12 @@ static void panic_halt_ipmi_set_timeout(void)
>  	/* Wait for the messages to be free. */
>  	while (atomic_read(&panic_done_count) != 0)
>  		ipmi_poll_interface(watchdog_user);
> -	atomic_add(1, &panic_done_count);
> +	atomic_inc(&panic_done_count);
>  	rv = __ipmi_set_timeout(&panic_halt_smi_msg,
>  				&panic_halt_recv_msg,
>  				&send_heartbeat_now);
>  	if (rv) {
> -		atomic_sub(1, &panic_done_count);
> +		atomic_dec(&panic_done_count);
>  		pr_warn("Unable to extend the watchdog timeout\n");
>  	} else {
>  		if (send_heartbeat_now)
> -- 
> 1.9.1
>