linux-kernel - Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201116160213.3de5280c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 16 Nov 2020 16:02:13 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Vladimir Oltean <olteanv@...il.com>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats
 support

On Mon, 16 Nov 2020 15:30:39 -0800 Florian Fainelli wrote:
> > What about RMON/RFC2819 style etherStatsPkts65to127Octets? We have a
> > number of switches supporting that style of counters, including the one
> > that Oleksij is adding support for, apparently (but not all switches
> > though). I suppose your M.O. is that anything standardizable is welcome
> > to be standardized via rtnetlink?
> > 
> > Andrew, Florian, any opinions here?
> 
> Settling on RMON/RFC2819 statistics would work for me, and hopefully is
> not too hard to get the various drivers converted to.

That would be grate! For RMON stats you may have slightly more legwork
to do on ethtool side, since IIRC the plumbing for stats over netlink
is (intentionally?) not there until we settle on how to handle
standardize-able counters.

I've only done pause stats 'cause those and FEC are the primary HW
stats my employer cares about :) I'm sure people would actually find
use for the RMON stats once they get standardized tho!

> With respect to Oleksij's patch, I would tend to accept it so we
> actually have more visibility into what standardized counters are
> available across switch drivers.

For a while now we have been pushing back on stats which have a proper
interface to be added to ethtool -S. So I'd expect the list of stats
exposed via ethtool will end up being shorter than in this patch.