lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Nov 2020 20:24:18 +0100 From: Jernej Škrabec <jernej.skrabec@...l.net> To: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Ezequiel Garcia <ezequiel@...labora.com> Cc: kernel@...labora.com, Jonas Karlman <jonas@...boo.se>, Hans Verkuil <hverkuil@...all.nl>, Nicolas Dufresne <nicolas.dufresne@...labora.com>, Philipp Zabel <p.zabel@...gutronix.de>, Maxime Ripard <mripard@...nel.org>, Paul Kocialkowski <paul.kocialkowski@...tlin.com>, Ezequiel Garcia <ezequiel@...labora.com> Subject: Re: [PATCH v2 2/9] media: cedrus: h264: Support profile and level controls Hi Ezequiel, sorry for late review. First of all, this patch doesn't break anything. However, see comment below. Dne petek, 13. november 2020 ob 22:51:14 CET je Ezequiel Garcia napisal(a): > Cedrus supports H.264 profiles from Baseline to High, > up to Level 5.1, except for the Extended profile > > Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE and > V4L2_CID_MPEG_VIDEO_H264_LEVEL so that userspace can > query the driver for the supported profiles and levels. > > Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com> > --- > drivers/staging/media/sunxi/cedrus/cedrus.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/ media/sunxi/cedrus/cedrus.c > index 9a102b7c1bb9..8b0e97752d27 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -103,6 +103,27 @@ static const struct cedrus_control cedrus_controls[] = { > .codec = CEDRUS_CODEC_H264, > .required = false, > }, > + { > + .cfg = { > + .id = V4L2_CID_MPEG_VIDEO_H264_PROFILE, > + .min = V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE, > + .def = V4L2_MPEG_VIDEO_H264_PROFILE_MAIN, > + .max = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH, > + .menu_skip_mask = > + BIT(V4L2_MPEG_VIDEO_H264_PROFILE_EXTENDED), > + }, > + .codec = CEDRUS_CODEC_H264, > + .required = false, > + }, > + { > + .cfg = { > + .id = V4L2_CID_MPEG_VIDEO_H264_LEVEL, > + .min = V4L2_MPEG_VIDEO_H264_LEVEL_1_0, > + .max = V4L2_MPEG_VIDEO_H264_LEVEL_5_1, I went through several datasheets and only newer ones (H6, H616) state max. supported level, which is 4.2. Please change it in next revision. After that, you can add Reviewed-by: Jernej Skrabec <jernej.skrabec@...l.net> Best regards, Jernej > + }, > + .codec = CEDRUS_CODEC_H264, > + .required = false, > + }, > { > .cfg = { > .id = V4L2_CID_MPEG_VIDEO_HEVC_SPS, > -- > 2.27.0 > >
Powered by blists - more mailing lists