linux-kernel - Re: [PATCH] drm/msm: Fix error return code in msm_drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1539aaff024566bc1e64eb7897ec6c7@codeaurora.org>
Date:   Tue, 17 Nov 2020 11:52:52 -0800
From:   abhinavk@...eaurora.org
To:     Wei Li <liwei391@...wei.com>
Cc:     Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rajesh Yadav <ryadav@...eaurora.org>,
        Sravanthi Kollukuduru <skolluku@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        guohanjun@...wei.com
Subject: Re: [PATCH] drm/msm: Fix error return code in msm_drm_init()

On 2020-11-16 18:36, Wei Li wrote:
> When it fail to create crtc_event kthread, it just jump to 
> err_msm_uninit,
> while the 'ret' is not updated. So assign the return code before that.
> 
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Li <liwei391@...wei.com>
Reviewed-by: Abhinav Kumar <abhinavk@...eaurora.org>
> ---
>  drivers/gpu/drm/msm/msm_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/msm_drv.c 
> b/drivers/gpu/drm/msm/msm_drv.c
> index 49685571dc0e..37a373c5ced3 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -506,6 +506,7 @@ static int msm_drm_init(struct device *dev, struct
> drm_driver *drv)
>  			"crtc_event:%d", priv->event_thread[i].crtc_id);
>  		if (IS_ERR(priv->event_thread[i].worker)) {
>  			DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n");
> +			ret = PTR_ERR(priv->event_thread[i].worker);
>  			goto err_msm_uninit;
>  		}